Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused thirdparty app #273

Merged
merged 2 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions products/ASC.Files/Core/Core/FileStorageService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ public class FileStorageService //: IFileStorageService
IEventBus eventBus,
EntryStatusManager entryStatusManager,
OFormRequestManager oFormRequestManager,
ThirdPartySelector thirdPartySelector,
ThumbnailSettings thumbnailSettings,
FileShareParamsHelper fileShareParamsHelper,
EncryptionLoginProvider encryptionLoginProvider,
Expand Down Expand Up @@ -1141,36 +1140,20 @@ public async Task<string> StartEditAsync<T>(T fileId, bool editingAlone = false,
{
try
{
IThirdPartyApp app;
if (editingAlone)
{
if (fileTracker.IsEditing(fileId))
{
throw new InvalidOperationException(FilesCommonResource.ErrorMessage_SecurityException_EditFileTwice);
}

app = thirdPartySelector.GetAppByFileId(fileId.ToString());
if (app == null)
{

await entryManager.TrackEditingAsync(fileId, Guid.Empty, authContext.CurrentAccount.ID, doc, await tenantManager.GetCurrentTenantIdAsync(), true);
}

//without StartTrack, track via old scheme
return await documentServiceHelper.GetDocKeyAsync(fileId, -1, DateTime.MinValue);
}

(File<string> File, Configuration<string> Configuration, bool LocatedInPrivateRoom) fileOptions;

app = thirdPartySelector.GetAppByFileId(fileId.ToString());
if (app == null)
{
fileOptions = await documentServiceHelper.GetParamsAsync(fileId.ToString(), -1, doc, true, true, false);
}
else
{
var (file, editable) = await app.GetFileAsync(fileId.ToString());
fileOptions = await documentServiceHelper.GetParamsAsync(file, true, editable ? FileShare.ReadWrite : FileShare.Read, false, editable, editable, editable, false);
}
var fileOptions = await documentServiceHelper.GetParamsAsync(fileId.ToString(), -1, doc, true, true, false);

var configuration = fileOptions.Configuration;
if (!configuration.EditorConfig.ModeWrite || !(configuration.Document.Permissions.Edit || configuration.Document.Permissions.ModifyFilter || configuration.Document.Permissions.Review
Expand Down
100 changes: 0 additions & 100 deletions products/ASC.Files/Core/HttpHandlers/ThirdPartyAppHandler.ashx.cs

This file was deleted.

110 changes: 0 additions & 110 deletions products/ASC.Files/Core/Log/BoxAppLogger.cs

This file was deleted.

Loading
Loading