-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLAIS5-4190 Add cma serverpark access to cma roles #352
BLAIS5-4190 Add cma serverpark access to cma roles #352
Conversation
f2fabf7
to
13af414
Compare
…lt Server Park" to "Server Parks" ClientConfig reads RoleToServerParksMap from json file Read role_to_serverparks_map_json from json file Rename RoleToServerParksMap to RoleToServerParksMap Server side RoleToServerParksDict config change Client side RoleToServerParksDict config changes fix: Add resolveJsonModule to tsconfig.server.json
13af414
to
ec9e152
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 47.50% 46.28% -1.22%
==========================================
Files 29 30 +1
Lines 640 659 +19
Branches 134 138 +4
==========================================
+ Hits 304 305 +1
- Misses 336 354 +18 ☔ View full report in Codecov by Sentry. |
…ed in separate ticket for adding more tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, clean code and works as expected.
🛠 Changes being made
Here give examples of the changes you've made in this pull request. Include an itemized list if you can. It'll help the reviewer
https://jira.ons.gov.uk/browse/BLAIS5-4190
✨ What's the context?
What's the context for the changes?
https://jira.ons.gov.uk/browse/BLAIS5-4190
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🧪 Test plan
How do you know the changes are safe to ship to production?
📸 Screenshots (optional)
If you made UI changes, what are the before an afters?
🏎 Quality check