Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling for the release page plus some refactoring #55

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

helenb
Copy link
Contributor

@helenb helenb commented Dec 9, 2024

NB this is still a work in progress as some elements require further design tweaks - particularly the census logos and the accreditation content.

What is the context of this PR?

  • Tidied up commenting on scss files
  • Refactored some heading styles to make them common to all pages
  • Moved release styles to the common-header
  • Fixed spacing with the accredited logo
  • Added conditionals around page content where necessary
  • Create a re-usable spacing class for streamfield and other content so we have consistent spacing between page blocks
  • Adjusted spacing below paragraphs for all rich text blocks after discussion with Gareth

How to review

In your local build, check out this branch, and view a release page. Check it in all it's various different states.

Follow-up Actions

List any follow-up actions (if applicable), like needed documentation updates or additional testing.

@helenb helenb requested a review from a team as a code owner December 9, 2024 10:28
@helenb helenb marked this pull request as draft December 9, 2024 10:28
{% else %}
{% set last_flush = True %}
{% endif %}
<div class="ons-grid ons-grid-flex-gap ons-grid-flex-gap--32">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is just to remove a wrapper class and re-indent.

@zerolab zerolab mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants