Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #1562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add CODEOWNERS file #1562

wants to merge 2 commits into from

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Dec 16, 2024

What is the context of this PR?

This adds the CODEOWNERS file as described in https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.

How to review

Check if file works as expected, the users/team's review is requested on a new PR.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@petechd petechd marked this pull request as ready for review December 16, 2024 12:17
@rmccar
Copy link
Contributor

rmccar commented Dec 16, 2024

Do we want to add any comments to explain what this means? Im not necessarily saying we should just raising it because I was wondering what people thought

@petechd
Copy link
Contributor Author

petechd commented Dec 16, 2024

Do we want to add any comments to explain what this means? Im not necessarily saying we should just raising it because I was wondering what people thought

It does not have any comments about the general purpose in the example in official docs, the only comments are detailed descriptions of what the syntax stands for, for each example in an example file.

@rmccar
Copy link
Contributor

rmccar commented Dec 16, 2024

Do we want to add any comments to explain what this means? Im not necessarily saying we should just raising it because I was wondering what people thought

It does not have any comments about the general purpose in the example in official docs, the only comments are detailed descriptions of what the syntax stands for, for each example in an example file.

Yeah I read them, I was just wondering what people thought. I guess we don't have comments for similar files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants