SDCSRM-185 Fix Dependabot test failures in rh-service

[ryangrundy7]

Motivation and Context

There's a few dependabot PRs that need to be updated, especially after we've upgraded to spring boot 3

What has changed

• Updated dependencies
• JSONObject from nimbus-jose-jwt was removed since they've moved to Gson instead. From the looks of it, the Payload doesn't need a JSONObject wrapper and we can just pass in the claims as a HashMap<String, Object>

How to test?

• Run the branch against the ATs
• Get a launch token from rh-ui and run it against the decrypt_token.sh script in ssdc-rm-dev-tools. The output should match what you'd expect from before this change.

Links

Trello
Jira

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (5cb62be) to head (498c93e).

Additional details and impacted files

@@             Coverage Diff              @@
##               main      #54      +/-   ##
============================================
+ Coverage     82.28%   85.90%   +3.62%     
- Complexity      210      215       +5     
============================================
  Files            45       45              
  Lines           666      667       +1     
  Branches         33       33              
============================================
+ Hits            548      573      +25     
+ Misses          102       81      -21     
+ Partials         16       13       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ryangrundy7]

https://jira.ons.gov.uk/browse/SDCSRM-185

[islas104]

I've reviewed the changes made in this PR, and I'm approving it for merge for the following reasons:

Dependency Updates: The updates to spring-boot-starter-parent, spring-cloud-gcp-dependencies, nimbus-jose-jwt, maven-pmd-plugin, and fmt-maven-plugin are aligned with the latest stable versions. This not only addresses the Dependabot test failures but also ensures that our project dependencies remain up-to-date and secure.

Code Quality and Simplification: The removal of unnecessary imports and adjustments in EncodeJws.java simplifies the code and removes dependencies on deprecated or unnecessary classes, such as the direct use of JSONObject from nimbus-jose-jwt.

Code Clarity Improvement: The changes in LaunchDataFieldSetter.java, specifically the addition of line breaks and clearer structuring of method calls, improve code readability and maintainability. It demonstrates attention to code quality and readability, which is crucial for ongoing project health.

Adherence to Project Standards: The modifications are consistent with our coding standards and best practices. The PR not only addresses the immediate issues flagged by Dependabot but also contributes to the overall quality and maintainability of the project.

In conclusion, this PR effectively addresses the identified Dependabot test failures while also making significant strides towards improving code quality, security, and maintainability. Excellent work on ensuring that our dependencies are current and that our code base remains clean and well-organized.