Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to slf4j #64

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Switched to slf4j #64

merged 1 commit into from
Apr 30, 2024

Conversation

KieranWardle
Copy link
Contributor

Motivation and Context

The logging framework we were using is no longer supported

What has changed

Switched to using Slf4j

@KieranWardle KieranWardle added the patch A non-feature change, e.g. bug or issue fix label Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 74.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 82.02%. Comparing base (77d2b65) to head (ca20d08).

Files Patch % Lines
...c/rhservice/messaging/ManagedMessageRecoverer.java 48.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #64      +/-   ##
============================================
- Coverage     82.30%   82.02%   -0.28%     
  Complexity      210      210              
============================================
  Files            45       45              
  Lines           667      690      +23     
  Branches         33       33              
============================================
+ Hits            549      566      +17     
- Misses          102      109       +7     
+ Partials         16       15       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KieranWardle KieranWardle merged commit abb2cc7 into main Apr 30, 2024
4 checks passed
@KieranWardle KieranWardle deleted the SDCSRM-376_switch-to-logback branch April 30, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A non-feature change, e.g. bug or issue fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants