Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to shared project #67

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

ryangrundy7
Copy link
Contributor

Motivation and Context

We're not sharing our pubsub topics anymore so no need to reference a shared project

What has changed

Removed mention of shared project

How to test?

  • Run make build
  • Run with the docker-dev PR and run the ATs.

Links

Jira

Screenshots (if appropriate):

@ryangrundy7 ryangrundy7 added the patch A non-feature change, e.g. bug or issue fix label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (6368ffd) to head (01b434f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #67   +/-   ##
=========================================
  Coverage     82.02%   82.02%           
  Complexity      210      210           
=========================================
  Files            45       45           
  Lines           690      690           
  Branches         33       33           
=========================================
  Hits            566      566           
  Misses          109      109           
  Partials         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryangrundy7 ryangrundy7 merged commit 8a3e186 into main Jul 15, 2024
4 checks passed
@ryangrundy7 ryangrundy7 deleted the SDCSRM-529-remove-references-to-shared-project branch July 15, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A non-feature change, e.g. bug or issue fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants