Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDCSRM-577 Bump common entities version and fix tests #243

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

AdamHawtin
Copy link
Contributor

@AdamHawtin AdamHawtin commented Jul 3, 2024

Motivation and Context

The common entities have been updated.

What has changed

  • Bump the common entities version
  • Fix tests that had null values in the action rule status

How to test?

No functional change, the tests should pass once the DDL repo change has been merged and the new artifact built.

Links

https://jira.ons.gov.uk/browse/SDCSRM-577

@AdamHawtin AdamHawtin added patch A non-feature change, e.g. bug or issue fix work in progress Work is still in progress on this change and removed work in progress Work is still in progress on this change labels Jul 3, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.22%. Comparing base (f7c4e3b) to head (6b1c6c2).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #243      +/-   ##
============================================
- Coverage     87.35%   87.22%   -0.13%     
+ Complexity      418      417       -1     
============================================
  Files            90       90              
  Lines          1589     1589              
  Branches        101      101              
============================================
- Hits           1388     1386       -2     
- Misses          147      148       +1     
- Partials         54       55       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdamHawtin AdamHawtin merged commit 44b1909 into main Jul 5, 2024
3 of 6 checks passed
@AdamHawtin AdamHawtin deleted the SDCSRM-577-make-action-rule-status-non-nullable branch July 5, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A non-feature change, e.g. bug or issue fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants