Upgrading to spring boot 3.2.2 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanks91
reviewed
Feb 16, 2024
| @@ -73,7 +73,7 @@ void processChunk() { | |||
| when(transformer.transformRow(job, jobRow, columnValidators, jobTypeProcessor.getTopic())) | |||
| .thenReturn(messageToPublish); | |||
|
|
|||
| ListenableFuture<String> listenableFuture = mock(ListenableFuture.class); | |||
| CompletableFuture<String> listenableFuture = mock(CompletableFuture.class); | |||
There was a problem hiding this comment.
Suggested change
| CompletableFuture<String> listenableFuture = mock(CompletableFuture.class); | |
| CompletableFuture<String> completableFuture = mock(CompletableFuture.class); |
dbanks91
approved these changes
Feb 19, 2024
hbrace
approved these changes
Feb 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=========================================
Coverage 92.05% 92.05%
Complexity 120 120
=========================================
Files 35 35
Lines 403 403
Branches 16 16
=========================================
Hits 371 371
Misses 29 29
Partials 3 3 ☔ View full report in Codecov by Sentry. |
ryangrundy7
deleted the
1288-upgrade-spring-boot-version-in-java-repos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Spring Boot 3 has been out for a while and Dependabot wants us to upgrade to it. There's quite a few changes which you look up for yourselves. I listed main changes to each repo on the ticket.
What has changed
PostgreSQLDialectHow to test?
make buildon the exception manager and uac qid service branchUAC_QID_SERVICE_BRANCH=1288-upgrade-spring-boot-version-in-java-repos EXCEPTION_MANAGER_BRANCH=1288-upgrade-spring-boot-version-in-java-repos make dev-build. This should build the expected ddl changes for you.make buildon the rest of the java servicesLinks
Trello
Screenshots (if appropriate):