regression_1041: give 5 seconds for /dev/tpm0 to appear #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Jan 15, 2025
jforissier
force-pushed
the
ftpm-timeout
branch
from
ea95eb5 to
ead50e7
Compare
host/xtest/regression_1000.c
Outdated
| found = true; | ||
| break; | ||
| } | ||
| (void)usleep(1000000); |
There was a problem hiding this comment.
sleep(1) without a void cast?
host/xtest/regression_1000.c
Outdated
| } | ||
| (void)usleep(1000000); | ||
| } | ||
| if (!found) { |
There was a problem hiding this comment.
Shouldn't we record an error?
There was a problem hiding this comment.
Indeed. Updated.
It does take some time for the kernel to probe the fTPM device, and therefore if regression_1041 is run immediately after boot it may fail. Add a 5 second timeout to make the test reliable. Signed-off-by: Jerome Forissier <[email protected]> Acked-by: Etienne Carriere <[email protected]> Acked-by: Jens Wiklander <[email protected]>
jforissier
force-pushed
the
ftpm-timeout
branch
from
699de06 to
caeb54b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does take some time for the kernel to probe the fTPM device, and therefore if regression_1041 is run immediately after boot it may fail. Add a 5 second timeout to make the test reliable.