Skip to content

Commit

Permalink
Fixed UWP and Xamarin build (#574)
Browse files Browse the repository at this point in the history
Fixed the failing Azure pipeline UWP build:
Changed generic EventHandler to now as PublishStateChangedEventHandler typed EventHandler. This fixed the errors in the UWP build.

Fixed the Xamarin build:
The msbuild for Android SDK 25 (Android 7.1) seems to be non-functional. Could not reproduce the exact same behavior locally - might also be caused by an error in the Azure pipeline configuration. (If the pipeline fails in the PR, I'll just remove the Xamarin related change...)
  • Loading branch information
maxschiffer authored Nov 9, 2023
1 parent 9f4f5d2 commit 0153c13
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Samples/Controls/Subscriptions/SubscriptionDlg.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ public SubscriptionDlg()

m_SessionNotification = new NotificationEventHandler(Session_Notification);
m_SubscriptionStateChanged = new SubscriptionStateChangedEventHandler(Subscription_StateChanged);
m_PublishStatusChanged = new EventHandler(Subscription_PublishStatusChanged);
m_PublishStatusChanged = new PublishStateChangedEventHandler(Subscription_PublishStatusChanged);
}
#endregion

#region Private Fields
private Subscription m_subscription;
private NotificationEventHandler m_SessionNotification;
private SubscriptionStateChangedEventHandler m_SubscriptionStateChanged;
private EventHandler m_PublishStatusChanged;
private PublishStateChangedEventHandler m_PublishStatusChanged;
#endregion

#region Public Interface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<OutputType>Library</OutputType>
<RootNamespace>XamarinClient.Droid</RootNamespace>
<AssemblyName>XamarinClient.Android</AssemblyName>
<TargetFrameworkVersion>v7.1</TargetFrameworkVersion>
<TargetFrameworkVersion>v8.1</TargetFrameworkVersion>
<AndroidApplication>True</AndroidApplication>
<AndroidResgenFile>Resources\Resource.designer.cs</AndroidResgenFile>
<AndroidResgenClass>Resource</AndroidResgenClass>
Expand Down Expand Up @@ -98,4 +98,4 @@
</ItemGroup>
<ItemGroup />
<Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" />
</Project>
</Project>

0 comments on commit 0153c13

Please sign in to comment.