GDS: fix Application unregistration in SQL DB for Winforms Server & fix private key storage in Pull Model GDS Client

[romanett]

Proposed changes

• GDS: fix Application unregistration in SQL DB for Winforms Server
• fix private key creation for New Certificate in Pull Model GDS Client

Related Issues

• Fixes #

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Enhancement (non-breaking change which adds functionality)
• Test enhancement (non-breaking change to increase test coverage)
• Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc.
• I have signed the CLA.
• I ran tests locally with my changes, all passed.
• I fixed all failing tests in the CI pipelines.
• I fixed all introduced issues with CodeQL and LGTM.
• I have added tests that prove my fix is effective or that my feature works and increased code coverage.
• I have added necessary documentation (if appropriate).
• Any dependent changes have been merged and published in downstream modules.

Further comments

[mregen]

Nuget versions mismatch, build error

[romanett]

Nuget versions mismatch, build error

@mregen locally my build works fine, can you provide an error message?

[mregen]

see https://github.com/OPCFoundation/UA-.NETStandard-Samples/pull/603/checks?check_run_id=24548958539
updating Nuget packages means all or nothing. Unfortunately dependabot has decided to be silent on our packages.

[sveinfolkeson]

The problem with private key is still present. When I debug I can see that already when I create the certificate for the first time it seems to be OK when I watch it in the certificate store, but the statements:

                            newCert = new X509Certificate2(privateKeyPFX, string.Empty, X509KeyStorageFlags.Exportable);
                            newCert = CertificateFactory.Load(newCert, true);

Returns newCert with 'newCert.PrivateKey' threw an exception of type 'System.Security.Cryptography.CryptographicException'