Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Xamarin Version to 5 #625

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Upgrade Xamarin Version to 5 #625

merged 3 commits into from
Sep 13, 2024

Conversation

romanett
Copy link
Contributor

@romanett romanett commented Jul 7, 2024

Proposed changes

Preparation for MAUI Upgrade.

ToDo:

  • Check if IOS still works
  • Request ReadExternalStoragePermission at Runtime ? (Not shure if this is the cause for the Exception occurring when connecting to a server (Access to the path"/storage/emulated/0/" is denied)

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett marked this pull request as ready for review September 13, 2024 06:12
@romanett
Copy link
Contributor Author

romanett commented Sep 13, 2024

@mregen i think we can merge this without further testing as the Samples we're already not fully functional before the Upgrade to xamarin 5. and WinUI works, so the shared library Code is okay.

@mregen mregen self-requested a review September 13, 2024 06:23
@mregen mregen merged commit 625b1e9 into master Sep 13, 2024
8 checks passed
@mregen mregen deleted the XamarinUpgrade branch September 13, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants