-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Server] Improve publishing operation to avoid discarding values in edge cases #2763
base: develop/main374
Are you sure you want to change the base?
[Server] Improve publishing operation to avoid discarding values in edge cases #2763
Conversation
…queueSize is used for DataValues / Events or a large number of monitored items is created in a single subscription
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop/main374 #2763 +/- ##
===================================================
+ Coverage 54.84% 55.40% +0.55%
===================================================
Files 349 349
Lines 66070 66081 +11
Branches 13556 13565 +9
===================================================
+ Hits 36235 36611 +376
+ Misses 25902 25486 -416
- Partials 3933 3984 +51 ☔ View full report in Codecov by Sentry. |
Applications/Quickstarts.Servers/SampleNodeManager/DataChangeMonitoredItem.cs
Outdated
Show resolved
Hide resolved
due to the breaking interface changes it has to be merged after a version bump |
This PR does not need to be merged to develop/durable as it is already included in #2683 |
@romanett lets keep this PR as draft for now, maybe we want to use it already before the durable subscription release is ready. |
Proposed changes
This PR improves publishing operation to avoid discarding values when a large queueSize is used for DataValues / Events or a large number of monitored items is created in a single subscription.
This fix changes the MonitoredItem Interface for the Publish Methods.
Types of changes
Checklist
Further comments
This PR is needed for reliable operation of durable subscriptions.