Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auto accept untrusted certificates for GetIssuerNoExceptionAsync … #2822

Conversation

KircMax
Copy link
Contributor

@KircMax KircMax commented Oct 28, 2024

Use AutoAcceptUntrustedCertificates in GetIssuerNoExceptionAsync to always get the issuers when not caring about the trust relation.

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@KircMax
Copy link
Contributor Author

KircMax commented Oct 28, 2024

with the adjustment the issuers are loaded:
image

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.07%. Comparing base (b2d715d) to head (a86af6a).

Files with missing lines Patch % Lines
...Core/Security/Certificates/CertificateValidator.cs 66.66% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2822      +/-   ##
==========================================
- Coverage   55.70%   55.07%   -0.63%     
==========================================
  Files         352      352              
  Lines       67332    67344      +12     
  Branches    13806    13809       +3     
==========================================
- Hits        37506    37089     -417     
- Misses      25792    26171     +379     
- Partials     4034     4084      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@romanett romanett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is supposed to return trusted issuers.
This code of this PR will tamper certificate validation.
The AutoAcceptUntrustedCertificates is specifically used in a later phase of the validation.
Further discussion needed, i am not yet shure about this change, just writing down my concerns

@KircMax KircMax closed this Oct 30, 2024
@KircMax KircMax deleted the KircMax/AddAutoAcceptUntrustedCertificates branch October 30, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use Ca-Signed Client Certificate
2 participants