fix domain and email aria labels (#2348)

Co-authored-by: Angel Montenegro <[email protected]>
ORCID · Sep 13, 2024 · 0e0c121 · 0e0c121
1 parent 32da256
commit 0e0c121
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/src/app/cdk/side-bar/modals/modal-email/modal-email.component.html b/src/app/cdk/side-bar/modals/modal-email/modal-email.component.html
@@ -128,8 +128,8 @@ <h2 class="orc-font-body-large" i18n="@@side-bar.emailAddressesUppercase">
               <app-visibility-selector
                 formControlName="visibility"
                 id="cy-email-visibility"
-                [ariaLabelPrivate]="ariaLabelVisibilityEmailTrustedParty"
-                [ariaLabelPublic]="ariaLabelVisibilityEmailTrustedParty"
+                [ariaLabelPrivate]="ariaLabelVisibilityEmailPrivate"
+                [ariaLabelPublic]="ariaLabelVisibilityEmailPublic"
                 [ariaLabelTrustedParty]="ariaLabelVisibilityEmailTrustedParty"
                 [itemTitle]="emailsForm.value[email.putCode].email"
                 [editable]="email.verified"
@@ -299,9 +299,9 @@ <h2 class="orc-font-body-large" i18n="@@side-bar.emailAddressesUppercase">
                 formControlName="visibility"
                 id="cy-domain-visibility"
                 [itemTitle]="domain.value"
-                [ariaLabelPrivate]="ariaLabelVisibilityEmailTrustedParty"
-                [ariaLabelPublic]="ariaLabelVisibilityEmailTrustedParty"
-                [ariaLabelTrustedParty]="ariaLabelVisibilityEmailTrustedParty"
+                [ariaLabelPrivate]="ariaLabelVisibilityDomainPrivate"
+                [ariaLabelPublic]="ariaLabelVisibilityDomainPublic"
+                [ariaLabelTrustedParty]="ariaLabelVisibilityDomainTrustedParty"
                 [mobile]="isMobile"
                 [privacy]="domain.visibility"
               ></app-visibility-selector>

diff --git a/src/app/cdk/side-bar/modals/modal-email/modal-email.component.ts b/src/app/cdk/side-bar/modals/modal-email/modal-email.component.ts
@@ -69,6 +69,9 @@ export class ModalEmailComponent implements OnInit, OnDestroy {
   ariaLabelVisibilityEmailPublic = $localize`:@@side-bar.ariaLabelEmailPublic:Set email visibility to Everyone`
   ariaLabelVisibilityEmailTrustedParty = $localize`:@@side-bar.ariaLabelEmailTrustedParties:Set email visibility to Trusted Parties`
   ariaLabelVisibilityEmailPrivate = $localize`:@@side-bar.ariaLabelEmailPrivate:Set email visibility to Only Me`
+  ariaLabelVisibilityDomainPublic = $localize`:@@side-bar.ariaLabelDomainVisibilityPublic:Set domain visibility to Everyone`
+  ariaLabelVisibilityDomainTrustedParty = $localize`:@@side-bar.ariaLabelDomainVisibilityTrustedParties:Set domain visibility to Trusted Parties`
+  ariaLabelVisibilityDomainPrivate = $localize`:@@side-bar.ariaLabelDomainVisibilityPrivate:Set domain visibility to Only Me`
   ariaOpenAccountSettings = $localize`:@@side-bar.ariaOpenAccountSettings:Open your ORCID account settings`
   deleteTooltip = $localize`:@@side-bar.deleteTooltip:You can't delete the only email address in your account`
   visibilityTooltip = $localize`:@@side-bar.visibilityTooltip:Visibility set to Only me`

diff --git a/src/locale/properties/side-bar/side-bar.en.properties b/src/locale/properties/side-bar/side-bar.en.properties
@@ -104,5 +104,8 @@ side-bar.ariaLabelOtherEmailPrivate=Set other email visibility to Only Me
 side-bar.ariaLabelEmailPublic=Set email visibility to Everyone
 side-bar.ariaLabelEmailTrustedParties=Set email visibility to Trusted Parties
 side-bar.ariaLabelEmailPrivate=Set email visibility to Only Me
+side-bar.ariaLabelDomainVisibilityPublic=Set domain visibility to Everyone
+side-bar.ariaLabelDomainVisibilityTrustedParties=Set domain visibility to Trusted Parties
+side-bar.ariaLabelDomainVisibilityPrivate=Set domain visibility to Only Me
 side-bar.ariaOpenAccountSettings=Open your ORCID account settings
 side-bar.notificationsAreSentToEmail=Notifications are sent to