Skip to content

Commit

Permalink
9522-qa-unable-to-scroll-down-inside-email-domains-interstitial-using…
Browse files Browse the repository at this point in the history
…-mobile-devices
  • Loading branch information
leomendoza123 committed Nov 28, 2024
1 parent 186eb83 commit 50c3cc0
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions src/app/core/login-interstitials/login-interstitials.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class LoginInterstitialsService {
this.interstitialService
.getInterstitialsViewed('DOMAIN_INTERSTITIAL')
.subscribe((viewed) => {
this.alreadySawSignDomainInterstitial = viewed
// this.alreadySawSignDomainInterstitial = viewed
})
this.toggleService
.getStateOf('LOGIN_DOMAINS_INTERSTITIAL')
Expand All @@ -48,10 +48,10 @@ export class LoginInterstitialsService {
userRecord.userInfo.EFFECTIVE_USER_ORCID

if (
isNotImpersonating &&
!this.userHasPublicDomains(userRecord.emails) &&
this.userHasPrivateDomains(userRecord.emails) &&
this.loginDomainsInterstitialEnabled &&
// isNotImpersonating &&
// !this.userHasPublicDomains(userRecord.emails) &&
// this.userHasPrivateDomains(userRecord.emails) &&
// this.loginDomainsInterstitialEnabled &&
!this.alreadySawSignDomainInterstitial
) {
this.alreadySawSignDomainInterstitial = true
Expand All @@ -68,6 +68,7 @@ export class LoginInterstitialsService {
disableClose: true,
autoFocus: false,
restoreFocus: false,
maxHeight: 'calc(100vh - 20px)',
})
return dialog.afterClosed()
}
Expand All @@ -81,4 +82,4 @@ export class LoginInterstitialsService {
userHasPrivateDomains(value: EmailsEndpoint): boolean {
return !!value.emailDomains.find((domain) => domain.visibility !== 'PUBLIC')
}
}
}

0 comments on commit 50c3cc0

Please sign in to comment.