style: Add missing class to link (#2161)

* style: Add missing class to link * fix: Update i18n attribute * fix: Only display Orcid iD in mobile version * fix: Update priority error message of record with multiple issues --------- Co-authored-by: Daniel Palafox <[email protected]>
ORCID · Feb 19, 2024 · a4dae6c · a4dae6c
1 parent d9fbcb4
commit a4dae6c
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/src/app/record/components/record-header/record-header.component.html b/src/app/record/components/record-header/record-header.component.html
@@ -112,7 +112,8 @@
               'orc-font-body-large': platform.columns12
             }"
           >
-            {{ orcidId }}
+            <ng-container *ngIf="!platform.columns12; else elseBlock">{{ isPublicRecord }}</ng-container>
+            <ng-template #elseBlock>{{ orcidId }}</ng-template>
           </h2>
           <div
             class="buttons-wrapper"

diff --git a/src/app/record/components/record-info/record-info.component.html b/src/app/record/components/record-info/record-info.component.html
@@ -6,7 +6,6 @@
     <ng-container
       *ngIf="
         userInfo.IS_LOCKED === 'true' &&
-        userInfo.IS_DEACTIVATED === 'false' &&
         !userInfo.PRIMARY_RECORD
       "
     >
@@ -37,7 +36,10 @@
     </ng-container>
 
     <ng-container
-      *ngIf="userInfo.IS_DEACTIVATED === 'true' && !userInfo.PRIMARY_RECORD"
+      *ngIf="
+        userInfo.IS_DEACTIVATED === 'true' &&
+        userInfo.IS_LOCKED === 'false' &&
+        !userInfo.PRIMARY_RECORD"
     >
       <p>
         <ng-container i18n="@@topBar.whenOrcidDeactivated">
@@ -61,11 +63,11 @@
       <p>
         <ng-container i18n="@@topBar.accountDeprecated">
           This account has been deprecated, please see account </ng-container
-        >&nbsp;<a [href]="userInfo.PRIMARY_RECORD">{{
+        >&nbsp;<a class="underline" [href]="userInfo.PRIMARY_RECORD">{{
           'https:' + baseUrl + userInfo.PRIMARY_RECORD
         }}</a
-        >&nbsp;<ng-container i18n="@@topBar.accountDeprecated2"
-          >for the latest information
+        >&nbsp;<ng-container i18n="@@topBar.forTheLastInformation"
+          >for the latest information.
         </ng-container>
       </p>
       <p>

diff --git a/src/locale/properties/top-bar/top-bar.en.properties b/src/locale/properties/top-bar/top-bar.en.properties
@@ -112,3 +112,4 @@ topBar.recordOwnerNotHaveAdded=The record owner may not have added information t
 topBar.findOutVisibility=Find out more about visibility settings in ORCID
 topBar.ariaLabelCopyOrcidId=Copy your ORCID iD to the clipboard
 topBar.ariaLabelViewPrintable=View a printable version of your ORCID record (Opens in new tab)
+topBar.forTheLastInformation=for the latest information.
diff --git a/src/locale/properties/top-bar/top-bar.rl.properties b/src/locale/properties/top-bar/top-bar.rl.properties
@@ -126,3 +126,4 @@ topBar.recordOwnerNotHaveAdded=RL
 topBar.findOutVisibility=RL
 topBar.ariaLabelCopyOrcidId=RL
 topBar.ariaLabelViewPrintable=RL
+topBar.forTheLastInformation=RL
diff --git a/src/locale/properties/top-bar/top-bar.xx.properties b/src/locale/properties/top-bar/top-bar.xx.properties
@@ -126,3 +126,4 @@ topBar.recordOwnerNotHaveAdded=X
 topBar.findOutVisibility=X
 topBar.ariaLabelCopyOrcidId=X
 topBar.ariaLabelViewPrintable=X
+topBar.forTheLastInformation=X