Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain aria labels #2348

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Fix domain aria labels #2348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
daa3423
fix domain and email aria labels
auumgn Sep 10, 2024
e5a0096
Merge branch 'main' into fix-domain-aria-labels
auumgn Sep 10, 2024
2b312a6
Merge branch 'main' into fix-domain-aria-labels
amontenegro Sep 13, 2024
153aff4
Merge branch 'main' into fix-domain-aria-labels
amontenegro Sep 13, 2024
1518dcb
Merge branch 'main' into fix-domain-aria-labels
amontenegro Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/app/cdk/side-bar/modals/modal-email/modal-email.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ <h2 class="orc-font-body-large" i18n="@@side-bar.emailAddressesUppercase">
<app-visibility-selector
formControlName="visibility"
id="cy-email-visibility"
[ariaLabelPrivate]="ariaLabelVisibilityEmailTrustedParty"
[ariaLabelPublic]="ariaLabelVisibilityEmailTrustedParty"
[ariaLabelPrivate]="ariaLabelVisibilityEmailPrivate"
[ariaLabelPublic]="ariaLabelVisibilityEmailPublic"
[ariaLabelTrustedParty]="ariaLabelVisibilityEmailTrustedParty"
[itemTitle]="emailsForm.value[email.putCode].email"
[editable]="email.verified"
Expand Down Expand Up @@ -299,9 +299,9 @@ <h2 class="orc-font-body-large" i18n="@@side-bar.emailAddressesUppercase">
formControlName="visibility"
id="cy-domain-visibility"
[itemTitle]="domain.value"
[ariaLabelPrivate]="ariaLabelVisibilityEmailTrustedParty"
[ariaLabelPublic]="ariaLabelVisibilityEmailTrustedParty"
[ariaLabelTrustedParty]="ariaLabelVisibilityEmailTrustedParty"
[ariaLabelPrivate]="ariaLabelVisibilityDomainPrivate"
[ariaLabelPublic]="ariaLabelVisibilityDomainPublic"
[ariaLabelTrustedParty]="ariaLabelVisibilityDomainTrustedParty"
[mobile]="isMobile"
[privacy]="domain.visibility"
></app-visibility-selector>
Expand Down
3 changes: 3 additions & 0 deletions src/app/cdk/side-bar/modals/modal-email/modal-email.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ export class ModalEmailComponent implements OnInit, OnDestroy {
ariaLabelVisibilityEmailPublic = $localize`:@@side-bar.ariaLabelEmailPublic:Set email visibility to Everyone`
ariaLabelVisibilityEmailTrustedParty = $localize`:@@side-bar.ariaLabelEmailTrustedParties:Set email visibility to Trusted Parties`
ariaLabelVisibilityEmailPrivate = $localize`:@@side-bar.ariaLabelEmailPrivate:Set email visibility to Only Me`
ariaLabelVisibilityDomainPublic = $localize`:@@side-bar.ariaLabelDomainVisibilityPublic:Set domain visibility to Everyone`
ariaLabelVisibilityDomainTrustedParty = $localize`:@@side-bar.ariaLabelDomainVisibilityTrustedParties:Set domain visibility to Trusted Parties`
ariaLabelVisibilityDomainPrivate = $localize`:@@side-bar.ariaLabelDomainVisibilityPrivate:Set domain visibility to Only Me`
ariaOpenAccountSettings = $localize`:@@side-bar.ariaOpenAccountSettings:Open your ORCID account settings`
deleteTooltip = $localize`:@@side-bar.deleteTooltip:You can't delete the only email address in your account`
visibilityTooltip = $localize`:@@side-bar.visibilityTooltip:Visibility set to Only me`
Expand Down
3 changes: 3 additions & 0 deletions src/locale/properties/side-bar/side-bar.en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,5 +104,8 @@ side-bar.ariaLabelOtherEmailPrivate=Set other email visibility to Only Me
side-bar.ariaLabelEmailPublic=Set email visibility to Everyone
side-bar.ariaLabelEmailTrustedParties=Set email visibility to Trusted Parties
side-bar.ariaLabelEmailPrivate=Set email visibility to Only Me
side-bar.ariaLabelDomainVisibilityPublic=Set domain visibility to Everyone
side-bar.ariaLabelDomainVisibilityTrustedParties=Set domain visibility to Trusted Parties
side-bar.ariaLabelDomainVisibilityPrivate=Set domain visibility to Only Me
side-bar.ariaOpenAccountSettings=Open your ORCID account settings
side-bar.notificationsAreSentToEmail=Notifications are sent to
Loading