Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 17 jakarta compatibility #50

Open
denis-yuen opened this issue May 1, 2023 · 6 comments
Open

Java 17 jakarta compatibility #50

denis-yuen opened this issue May 1, 2023 · 6 comments

Comments

@denis-yuen
Copy link

Working on the migration ourselves, noting that this library makes heavy use of javax.xml annotations.

Partial details at https://blogs.oracle.com/javamagazine/post/its-time-to-move-your-applications-to-java-17-heres-why-and-heres-how
While at it, I think there a bunch of other dependencies that change due to the jakarta migration. Glancing at https://mvnrepository.com/artifact/org.orcid/orcid-model/3.2.0

A bunch of other dependencies also change due to the whole jakarta migration

javax.annotation/javax.annotation-api -> lakarta.annotation:jakarta.annotation-api
io.swagger.core.v3/swagger-jaxrs2 -> io.swagger.core.v3:swagger-jaxrs2-jakarta
javax.annotation/javax.annotation-api -> jakarta.annotation:jakarta.annotation-api

@denis-yuen
Copy link
Author

May be similar to https://github.com/dockstore/swagger-java-quay-client/pull/6/files for an equivalent migration that we're working on

@amontenegro
Copy link
Member

Hi @denis-yuen! Thanks for your comments, we are planning in moving to Java 17, however, this will not happen until next year, since we will need several other dependencies to be upgraded before and there will be a big refactoring needed to make our app work with the jakarta libraries.

@tdonohue
Copy link

tdonohue commented Mar 6, 2024

Any updates on when Java 17 / Jakarta compatibility is coming? This is becoming a major issue for DSpace as we are attempting to move to Java 17 / Jarkarta (DSpace/DSpace#9321), and doing so appears to break all ORCID integrations.

@tdonohue
Copy link

tdonohue commented Mar 7, 2024

Hmm... It appears there may already be an Jakarta version? I'm not sure where/how this is being maintained, but I just noticed an org.orcid > orcid-model-jakarta Maven artifact in Maven Central: https://mvnrepository.com/artifact/org.orcid/orcid-model-jakarta/3.3.0

@denis-yuen
Copy link
Author

That's actually our attempt at updating in the thread linked above. I'm surprised Maven Central picked it up.

I think we were able to run the unit tests, but we're only using it a light way (retrieving author names given an id).
You're all welcome to try it and/or use it to speed up the creating an official update.

@TomDemeranville
Copy link
Contributor

This library is the same one we use to run our backend services and we update it in line with those.

As @amontenegro says, we're at least a year away from Java 17 so it's not going to move to Jakarta for quite some time.

The best way forward is probably to generate your own model using our XML schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants