Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockstore release #2

Merged
merged 4 commits into from
May 8, 2023
Merged

Dockstore release #2

merged 4 commits into from
May 8, 2023

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented May 2, 2023

This is our own branch for temporary release to our artifactory. We'll make a contribution back to orcid after testing

Test update needed for dockstore 1.15 compatibility

  • jarkara co-ordinates

Part of dockstore/dockstore#5483

@denis-yuen denis-yuen self-assigned this May 2, 2023
@denis-yuen denis-yuen marked this pull request as ready for review May 5, 2023 20:40
@denis-yuen denis-yuen requested review from a team, david4096, hyunnaye, svonworl, coverbeck and kathy-t and removed request for a team May 5, 2023 20:41
Copy link

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, 507 files changed. I'll confess my review wasn't the most in-depth, although it all seems pretty straightforward.

@denis-yuen
Copy link
Member Author

Yikes, 507 files changed. I'll confess my review wasn't the most in-depth, although it all seems pretty straightforward.

Yeah. for these supporting libraries, only the pom.xml is important to review. All the Java changes are just imports and package locations

@denis-yuen denis-yuen merged commit a756554 into master May 8, 2023
@denis-yuen denis-yuen deleted the dockstore_release branch May 8, 2023 17:55
@denis-yuen
Copy link
Member Author

Follow-up in ORCID#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants