9273-bugs-on-the-registry-due-the-home-page-project

ORCID · Jun 14, 2024 · ef9dd1c · ef9dd1c
1 parent 9799663
commit ef9dd1c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/.github/workflows/prod-deploy.yml b/.github/workflows/prod-deploy.yml
@@ -39,17 +39,17 @@ jobs:
         uses: reggionick/s3-deploy@v4
         with:
           folder: dist
-          bucket: ${{env.QA_AWS_BUCKET}}
+          bucket: ${{secrets.QA_AWS_BUCKET}}
           bucket-region: ${{ secrets.AWS_REGION }}
-          dist-id: ${{env.QA_CLOUDFRONT_DIST_ID}}
+          dist-id: ${{secrets.QA_CLOUDFRONT_DIST_ID}}
           invalidation: /
           delete-removed: true
           no-cache: true
           private: true
           files-to-include: '{.*/**,**}'
         env:
-          AWS_ACCESS_KEY_ID: ${{ env.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ env.AWS_SECRET_ACCESS_KEY }}
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           AWS_REGION: 'us-east-1'
 
       - name: Validate QA Deployment
@@ -85,17 +85,17 @@ jobs:
         uses: reggionick/s3-deploy@v4
         with:
           folder: dist
-          bucket: ${{ env.FALLBACK_AWS_BUCKET }}
+          bucket: ${{ secrets.FALLBACK_AWS_BUCKET }}
           bucket-region: ${{ secrets.AWS_REGION }}
-          dist-id: ${{ env.FALBACK_CLOUDFRONT_DIST_ID }}
+          dist-id: ${{ secrets.FALBACK_CLOUDFRONT_DIST_ID }}
           invalidation: /
           delete-removed: true
           no-cache: true
           private: true
           files-to-include: '{.*/**,**}'
         env:
-          AWS_ACCESS_KEY_ID: ${{ env.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ env.AWS_SECRET_ACCESS_KEY }}
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           AWS_REGION: 'us-east-1'
 
       - name: Validate Fallback Deployment
@@ -132,17 +132,17 @@ jobs:
         uses: reggionick/s3-deploy@v4
         with:
           folder: dist
-          bucket: ${{ env.PROD_AWS_BUCKET }}
+          bucket: ${{ secrets.PROD_AWS_BUCKET }}
           bucket-region: ${{ secrets.AWS_REGION }}
-          dist-id: ${{ env.PROD_CLOUDFRONT_DIST_ID }}
+          dist-id: ${{ secrets.PROD_CLOUDFRONT_DIST_ID }}
           invalidation: /
           delete-removed: true
           no-cache: true
           private: true
           files-to-include: '{.*/**,**}'
         env:
-          AWS_ACCESS_KEY_ID: ${{ env.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ env.AWS_SECRET_ACCESS_KEY }}
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           AWS_REGION: 'us-east-1'
 
       - name: Validate Production Deployment

diff --git a/.github/workflows/qa-deploy.yml b/.github/workflows/qa-deploy.yml
@@ -61,12 +61,12 @@ jobs:
           echo "Script failed, raising an error."
           exit 1
 
-      - name: Upload WordPress Staging HTML to S3
+      - name: Upload HTML to S3
         uses: reggionick/s3-deploy@v4
         if: ${{ inputs.environment != 'PROD' }}
         with:
           folder: dist
-          bucket: orcid-qa-public-page
+          bucket: ${{secrets.QA_AWS_BUCKET}}
           bucket-region: ${{ secrets.AWS_REGION }}
           dist-id: ${{secrets.QA_CLOUDFRONT_DIST_ID}}
           invalidation: /
@@ -157,15 +157,15 @@ jobs:
         uses: reggionick/s3-deploy@v4
         with:
           folder: dist
-          bucket: ${{env.QA_AWS_BUCKET}}
+          bucket: ${{secrets.QA_AWS_BUCKET}}
           bucket-region: ${{ secrets.AWS_REGION }}
-          dist-id: ${{env.QA_CLOUDFRONT_DIST_ID}}
+          dist-id: ${{secrets.QA_CLOUDFRONT_DIST_ID}}
           invalidation: /
           delete-removed: true
           no-cache: true
           private: true
           files-to-include: '{.*/**,**}'
         env:
-          AWS_ACCESS_KEY_ID: ${{ env.AWS_ACCESS_KEY_ID }}
-          AWS_SECRET_ACCESS_KEY: ${{ env.AWS_SECRET_ACCESS_KEY }}
-          AWS_REGION: ${{ env.AWS_REGION }}
+          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
+          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+          AWS_REGION: ${{ secrets.AWS_REGION }}