Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pre-notches with differing orientations #71

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

pabloseleson
Copy link
Collaborator

No description provided.

@pabloseleson pabloseleson requested a review from streeve November 17, 2023 14:49
Copy link
Collaborator

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to add to the examples/CMakeLists.txt. And let's rename random_cracks.cpp

examples/multiple_cracks.cpp Outdated Show resolved Hide resolved
examples/multiple_cracks.cpp Outdated Show resolved Hide resolved
examples/multiple_cracks.cpp Outdated Show resolved Hide resolved
examples/multiple_cracks.cpp Outdated Show resolved Hide resolved
examples/multiple_cracks.cpp Outdated Show resolved Hide resolved
@streeve
Copy link
Collaborator

streeve commented Jan 6, 2025

@kinanbezem7 this includes most of the changes needed for a more complex cut, like a circular hole. It's unmerged because of issues across MPI boundaries, but we could restrict usage and come back to it later

@kinanbezem7
Copy link

@kinanbezem7 this includes most of the changes needed for a more complex cut, like a circular hole. It's unmerged because of issues across MPI boundaries, but we could restrict usage and come back to it later

@streeve Thanks for replying so quickly, Yes this looks very similar to what I was trying to do. It may be necessary for void studies as bonds will easily reach over small spherical voids.

@pabloseleson
Copy link
Collaborator Author

pabloseleson commented Jan 23, 2025

@streeve The example is running, but we still have the MPI communication issue. Here is an example ran with "mpirun -N 8":


RC_MPI

@streeve
Copy link
Collaborator

streeve commented Jan 23, 2025

The example is running, but we still have the MPI communication issue.

@pabloseleson fixed the MPI issue. Let me know if it works on your end and also remove the copied file

@streeve streeve changed the title Initial version of multiple pre-notches Enable pre-notches with differing orientations Jan 23, 2025
@pabloseleson
Copy link
Collaborator Author

pabloseleson commented Jan 23, 2025

It seems working now. Here is a new result with "mpirun -N 8":

Run_MPI_fixed

@streeve streeve merged commit 526a136 into ORNL:main Jan 23, 2025
14 checks passed
@streeve streeve deleted the multi_crack branch January 23, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants