-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalized white space in filenames #20
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a0708e5
Normalized white space in filenames
jekuaitk 6d163b7
Upgraded actions php version
jekuaitk be32d63
Cleanup
jekuaitk ff4d20b
Update command docs
jekuaitk a384e2a
Trimmed document filename
jekuaitk 53c7d8e
Upgraded to latest getorganized api client
jekuaitk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
services: | ||
drush_command_example.commands: | ||
class: \Drupal\os2forms_get_organized\Commands\ArchiveCommands | ||
tags: | ||
- { name: drush.command } | ||
arguments: | ||
- '@Drupal\os2forms_get_organized\Helper\ArchiveHelper' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<?php | ||
|
||
namespace Drupal\os2forms_get_organized\Commands; | ||
|
||
use Drupal\os2forms_get_organized\Helper\ArchiveHelper; | ||
use Drupal\webform\Entity\WebformSubmission; | ||
use Drush\Commands\DrushCommands; | ||
use Symfony\Component\Console\Style\SymfonyStyle; | ||
|
||
/** | ||
* Drush command file. | ||
*/ | ||
class ArchiveCommands extends DrushCommands { | ||
|
||
public function __construct( | ||
private readonly ArchiveHelper $archiveHelper, | ||
) { | ||
parent::__construct(); | ||
} | ||
|
||
/** | ||
* A custom Drush command to displays the given text. | ||
* | ||
* @param string $submissionId | ||
* The submission id. | ||
* @param string $handlerId | ||
* The handler id. | ||
* | ||
* @command os2forms:get-organized:archive | ||
*/ | ||
public function archive(string $submissionId, string $handlerId): void { | ||
|
||
$io = new SymfonyStyle($this->input(), $this->output()); | ||
|
||
/** @var \Drupal\webform\WebformSubmissionInterface|null $submission */ | ||
$submission = WebformSubmission::load($submissionId); | ||
|
||
if (!$submission) { | ||
$io->error(sprintf('Webform submission with id %s could not be found.', $submissionId)); | ||
|
||
return; | ||
} | ||
|
||
try { | ||
$handler = $submission->getWebform()->getHandler($handlerId); | ||
} | ||
catch (\Exception $e) { | ||
$io->error($e->getMessage()); | ||
|
||
return; | ||
} | ||
|
||
$handlerConfig = $handler->getConfiguration(); | ||
|
||
$this->archiveHelper->archive($submissionId, $handlerConfig['settings']); | ||
|
||
$io->success(sprintf('Successfully archived webform submission with id %s ', $submissionId)); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be worth trimming the value to get rid of any leading and trailing whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trimmed in a384e2a!