Fix forever spinners in edit BC sessions #4736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4692 by adding a listener for window
pageshowevent and then checkingevent.persistedto make sure the page is being pulled from the browser cache and not reloaded. This may be unnecessary (we may want to remove the spinners every time the sessions index is opened) but this solves the original issue of the browser back button breaking spinners. Because these changes were added tobindFullPageSpinnerEvent, this will also fix this behavior on all the other pages that use this functionality.In doing this update, I did notice a second spinner div,
#full_page_spinner(cf.#full-page-spinnerused here) which is exclusively used by sweet alert, and IIRC we have a ticket to refactor. In the mean time, I added some comments and grouped the different sets of spinner functions together to reduce confusion.