-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] i.sentinel3.import: New addon to import Sentinel-3 data #612
base: grass7
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only checked the manual so far
option, a regular expression for filtering the file names should be given, e.g. | ||
"0179_076_100_0900_LN2" for importing only specific tiles. | ||
<p> | ||
The <em>Sentinel-3</em> format is currently not supported by GDAL and consists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does QGIS uses then to open the nc files within the S3 zip files? I tested with a S3SY2VG1 product. A double click just opens the ndvi layer in QGIS and r.import
works just fine for that layer as well. Maybe, this statement is a bit too strong or only valid for S3 LST products...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the semi automated classification plugin? That one has a similar (but not the same) workaround for the S3-format...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, plain QGIS opens the .nc
mentioned file just fine, I do not use the semi automated classification plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for clarifying.
Yes, QGIS does open the .nc
but - at least the QGIS 3.16 version I am running does not resolve the geometrical information correctly. The image is flipped and distorted....
The sentinel-3 format is pretty peculiar and one needs to combine the geometry and data nc files in order to get a reasonble geographical representation of the data....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying and bearing with me. My focus has been on SLSTR. So, the different products seem to come in different formats / packaging also across processing levels...
So a "final" i.sentinel3.import
module should support the formats for the different instruments
- Sentinel-3 OLCI
- Sentinel-3 SLSTR
- Sentinel-3 Synergy
- Sentinel-3 Altimetry
for level 1 and 2.
Not sure if I find the time to investigate and implement all of them (can be as simple as r.import
/r.in.gdal
/r.external
).
In any case this should be made clear in the documentation, as you correctly point out...
src/imagery/i.sentinel/i.sentinel3.import/i.sentinel3.import.html
Outdated
Show resolved
Hide resolved
src/imagery/i.sentinel/i.sentinel3.import/i.sentinel3.import.html
Outdated
Show resolved
Hide resolved
src/imagery/i.sentinel/i.sentinel3.import/i.sentinel3.import.html
Outdated
Show resolved
Hide resolved
src/imagery/i.sentinel/i.sentinel3.import/i.sentinel3.import.html
Outdated
Show resolved
Hide resolved
src/imagery/i.sentinel/i.sentinel3.import/i.sentinel3.import.html
Outdated
Show resolved
Hide resolved
<div class="code"><pre> | ||
i.sentinel3.import -p input="data" nprocs=4 modified_before="2021-09-09" product=LST basename=S3_LST | ||
|
||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "data"? Are the quotes necessary there? Also, maybe put some of the resulting printed info as example and not only the ...
;)
src/imagery/i.sentinel/i.sentinel3.import/i.sentinel3.import.py
Outdated
Show resolved
Hide resolved
I pulled your branch and tested with:
and I thought it would import everything, but I get:
However, the LST_in is there... what am I doing wrong?? Also, seems the user should set the region resolution before hand, right? I get some pretty course pixels in the bands that do get imported... Maybe a full example in the manual would be useful. |
src/imagery/i.sentinel/i.sentinel3.import/i.sentinel3.import.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Veronica Andreo <[email protected]>
Thanks, @veroandreo for reviewing. |
Nothing, a bug in the code. Thanks for pointing out.
Yes, that is mentioned in the manual. However, the default could also be to use the "native" resolution and extent from the scene (Markus mentioend the irregularities in the raster alignment there so this would be a rough approximation) and an |
There seems to be Synergy product in the input directory that does not get filtered out:
Right, that is mentioned in the manual. But resolution and extent could be grabbed from the data and a temporary region set for import accordingly.... |
If we want to make it closer to include in the repo, we might need to target the new default branch, grass8. |
Using "Edit" next to the PR title would let us change the base to
Would that be ok? |
FYI: I am currently re-working the PR / module... |
Nice! Mark the PR ready to review when you want us to take a new look on it ;) |
The Sentinel-3 data has a really peculiar format that is not supported by GDAL.
This module implements import based on
numpy
andnetCDF4
. Although it should be working in general, thorough review of the import procedure (and the geometric acceptability) would be very much appreciated.(Optional/additional) import as verctor points would be easy to implement if that would be an advantage...