style: Fix unused-import (F401) #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… __all__ in __init__
Ignored inline where the import is justified and isn't to fix later, and ignored in a per-file exclusion where the imports seemed to be for commented-out test case lines
github-actions
bot
added
vector
github-actions
bot
added
temporal
echoix
requested review from
petrasovaa and
wenzeslaus
and removed request for
wenzeslaus
|
How does the |
It explicitly lists what is available (exposed) when using star imports with the https://docs.python.org/3/tutorial/modules.html#importing-from-a-package |
|
@arohanajit Just to let you know that this PR will fix all (or most known, detected through ruff's implementation) of the F401, so you don't spend time in it. It's just still waiting to be merged. |
petrasovaa
reviewed
Oct 23, 2024
petrasovaa
reviewed
Oct 23, 2024
petrasovaa
reviewed
Oct 23, 2024
echoix
commented
Oct 23, 2024
Co-authored-by: Anna Petrasova <[email protected]>
petrasovaa
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff rule: https://docs.astral.sh/ruff/rules/unused-import/
Also adjusted the flake8 config file.
These commits started from an exploratory branch last week where I was profiling temporal tests. Removing an import of SimpleModule when not needed ended up with a measurable improvement in temporal/t.rast.accumulate/testsuite/test_accumulation.py, when removing all cases except one, and benchmarking with hyperfine (10 runs) each case, on Windows and Linux. I don't have the correct output for these isolated changes, as it was combined with more changes, but if combined with using t.remove with 3 layers in the input argument instead of calling t.remove 3 times, the fastest case was 1.18x faster than base, and 1.15x faster than base (I don't remember what conditions it was, but there was one less change). But the base was already modified by a change in PLY, sot it doesn't match exactly what was on main here.
The other change to t.remove will be in another PR.