Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.report: Updated instance checks #4618

Merged
merged 1 commit into from
Oct 31, 2024
Merged

v.report: Updated instance checks #4618

merged 1 commit into from
Oct 31, 2024

Conversation

arohanajit
Copy link
Contributor

used isinstance() instead of == for type checks

@github-actions github-actions bot added vector Related to vector data processing Python Related code is in Python module labels Oct 30, 2024
echoix
echoix approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, it's correct and better Python than before, but I'm not sure why the code looked only for the first item if it is an int and boxes it into a list.

@petrasovaa petrasovaa merged commit 00f51c9 into OSGeo:main Oct 31, 2024
25 of 26 checks passed
@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
module Python Related code is in Python vector Related to vector data processing
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arohanajit @echoix @petrasovaa