wxGUI: Fixed bare 'except' for psmap/ #4623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can the title better represent what is changed here? E722 isn't fixed for all wxGUI, only one file is fixed here and other wxGUI remains |
arohanajit
changed the title
petrasovaa
reviewed
Nov 1, 2024
| @@ -1049,7 +1049,7 @@ def makePSFont(self, textDict): | |||
| fn = wx.Font( | |||
| pointSize=fontsize, family=family, style=style, weight=weight, face=face | |||
There was a problem hiding this comment.
Looks like the parameters need to be updated:
Suggested change
| pointSize=fontsize, family=family, style=style, weight=weight, face=face | |
| pointSize=fontsize, family=family, style=style, weight=weight, faceName=face |
petrasovaa
reviewed
Nov 1, 2024
| @@ -1049,7 +1049,7 @@ def makePSFont(self, textDict): | |||
| fn = wx.Font( | |||
| pointSize=fontsize, family=family, style=style, weight=weight, face=face | |||
| ) | |||
| except: | |||
| except (ValueError, wx.PyAssertionError): | |||
petrasovaa
reviewed
Nov 1, 2024
| @@ -1071,7 +1071,7 @@ def getTextExtent(self, textDict): | |||
| dc.SetFont(fn) | |||
| w, h, lh = dc.GetFullMultiLineTextExtent(textDict["text"]) | |||
| return (w, h) | |||
| except: | |||
| except (wx.PyAssertionError, ValueError): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace bare except with specific font creation error handling
except (ValueError, wx.PyAssertionError)inmakePSFont()to handle invalid font parameters and system font failuresImprove text measurement error handling
except (wx.PyAssertionError, ValueError)ingetTextExtent()for device context and text measurement failures