Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.fillnulls: Modified tests for r.fillnulls module #5026

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

r.fillnulls: Modified tests for r.fillnulls module #5026

wants to merge 4 commits into from

Conversation

Shreshth-Malik
Copy link
Contributor

Modifications:

  • Added tests for bicubic interpolation.
  • Implemented flags like lambda.
  • Included tests for r.fillnulls with raster masks.

@github-actions github-actions bot added raster Related to raster data processing Python Related code is in Python module tests Related to Test Suite labels Feb 2, 2025
petrasovaa
petrasovaa requested changes Feb 10, 2025
View reviewed changes
scripts/r.fillnulls/testsuite/test_r_fillnulls.py
"range": 73.6245880126953,
"variance": 288.817309946793,
},
precision=1e-6,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is precision is fine, but then you don't need so many decimal places in the reference values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shreshth-Malik @petrasovaa