v.build: added tests for v.build module #5061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vector
petrasovaa
requested changes
Feb 7, 2025
|
|
||
| cls.use_temp_region() | ||
| gs.run_command("v.edit", map="test_3x3_map", tool="create", overwrite=True) | ||
| gs.run_command("g.region", n=3, s=0, e=3, w=0, res=1) |
There was a problem hiding this comment.
You don't need to set region for vector processing, it applies to raster operations only
| """Set up a temporary region and create vector map with test features.""" | ||
|
|
||
| cls.use_temp_region() | ||
| gs.run_command("v.edit", map="test_3x3_map", tool="create", overwrite=True) |
There was a problem hiding this comment.
Use instead something like this:
gs.write_command("v.in.ascii", input="-", stdin=input_data, output=...)
There was a problem hiding this comment.
Embed this inside the test file, no need to have a separate file. Alternatively it would go in testsuite/data/
|
|
||
| # Compare the dictionaries | ||
| if self.build_module == self.expected_output: | ||
| print("Outputs match!") |
There was a problem hiding this comment.
Use assert methods, not prints
petrasovaa
requested changes
Feb 11, 2025
| flags="n", | ||
| overwrite=True, | ||
| ) | ||
| # Run v.build (with multiple dump options) and store its output in a class variable. |
There was a problem hiding this comment.
Use read_command, the output is not meant to be parsed into a dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tests for the
v.buildmodule for various options includingbuild, dump, sdump, cdump, fdump.The additional text file is used to validate the output.