-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Consider source path with underscores #5386
Conversation
Perhaps we can extract the file name here with get_filename_component? |
Here I'm referring to L17, where we only extract the locale. |
Yes, just extracting filename components early would be ideal. |
Something like this might work, replacing L16: set(_locales)
foreach(_locale ${po_files})
get_filename_component(_loc ${_locale} NAME)
list(APPEND _locales ${_loc})
endforeach() |
Looks good to me! (#5426 is a blocker for merging any PR currently.) |
This PR fixes locale CMake build when the GRASS source path contains underscores. For example,
conda-build
creates a temporary build directory using timestamp with an underscore (e.g.,.../envs/grass-conda/conda-bld/grass_1741956650154/work/build
).Needs testing on Windows...