wxGUI: Fix SIM115: Use context managers for file operations in image2target module #5404
+83
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
reviewed
Mar 18, 2025
Comment on lines
164
to
165
| finally: | ||
| f.close() |
There was a problem hiding this comment.
What should happen if the try fails? Is the rest of the function / callers working correctly if it silently fails?
Comment on lines
362
to
363
| finally: | ||
| f.close() |
There was a problem hiding this comment.
Same thing. Also, after getting out of a context manager, is f.close() still valid ? Does it error out? Is there a way for you to try one of it manually when running the gui?
Comment on lines
1232
to
1234
| # pylint: disable=C2801 | ||
| # ruff: noqa: PLC2801 | ||
| ColumnSorterMixin.__init__(self, ncols) |
There was a problem hiding this comment.
This seems for your other PR, where I'm not sure it works as intended for a next line. Teach me and show me if I'm wrong
Comment on lines
2054
to
2055
| finally: | ||
| f.close() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace direct open() calls with context managers (with statements) in ii2t_manager.py for proper file handling with automatic closing even when exceptions occur. Improved by replacing open/read pattern with Path.read_text() to fix FURB101 warning. Also removed ruff code warnings