-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
g.proj: Add JSON support #5419
g.proj: Add JSON support #5419
Conversation
Signed-off-by: Nishant Bansal <[email protected]>
Could we re-run this CI? The error does not seem to be related. Errors in:
/d/a/grass/grass/lib/db/dbmi_driver
/d/a/grass/grass/db/drivers/sqlite
/d/a/grass/grass/db/drivers/postgres
/d/a/grass/grass/db/drivers/dbf
/d/a/grass/grass/db/drivers/ogr
/d/a/grass/grass/db/drivers/odbc |
@petrasovaa, Could you please review this PR when you have a moment? pinging in case it was missed. |
After discussing this with @wenzeslaus, we suggest adding the WKT (-w), proj4 (-j) and shell (-g) into the format option: Sorry for more changes again, but I think this will make more sense. |
Should I remove the JSON format for the -w and -j flags, or should I use
Should |
Good questions. I meant removing the JSON. I wouldn't do multiple outputs.
Without -p there should be no printing, so e.g. |
Signed-off-by: Nishant Bansal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small suggestions, looks great!
Signed-off-by: Nishant Bansal <[email protected]>
ref: #4104
This pull request integrates to add JSON output support to the
g.proj
module. With these changes,g.proj
now supports output in JSON format when invoked with the-p
flag.The behaviour is as follows:
NOTES: The code changes are largely based on the modifications introduced in #4104 with additional tweaks to address all review comments.