cmake: Fix PATH variable quoting for WSL environments with spaces in directories #6443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add quotes around PATH variable expansion to properly handle paths with spaces in the grass_env_command for non-Windows systems. This ensures consistent path handling across different Unix-like environments.
…ries Add quotes around PATH variable expansion in grass_env_command for Unix systems to properly handle Windows paths with spaces when running GRASS in WSL. This prevents path parsing issues that can occur when WSL mounts Windows directories containing spaces (e.g., 'Program Files') in the PATH.
|
Is CMake 3.25 finally available to us? If so, we could use the env modification feature, https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-E-arg-env, https://cmake.org/cmake/help/latest/prop_test/ENVIRONMENT_MODIFICATION.html#prop_test:ENVIRONMENT_MODIFICATION and use the portable path_list_append/path_list_prepend. Also, maybe using some path handling CMake utilities like https://cmake.org/cmake/help/latest/command/cmake_path.html#cmake-path-to-native-path-list. I thought I had already read something that mentioned the space handling, but I couldn’t refind it yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add quotes around PATH variable expansion in grass_env_command for Unix systems to properly handle Windows paths with spaces when running GRASS in WSL. This prevents path parsing issues that can occur when WSL mounts Windows directories containing spaces (e.g., 'Program Files') in the PATH.
@HuidaeCho