Skip to content

wxGUI/datacatalog: fix adding newly created project into projects tree only once #6453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

wxGUI/datacatalog: fix adding newly created project into projects tree only once #6453

wants to merge 2 commits into from
+13 −11

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Oct 4, 2025

Fixes #6452.

@tmszi
wxGUI/datacatalog: fix adding newly created project into projects tre…
20bc3de 
…e only once

When newly project is created into new GRASS database directory,
which is not added into data catalog GRASS databases tree (different
from the current default).
@tmszi tmszi added this to the 8.5.0 milestone Oct 4, 2025
@tmszi tmszi self-assigned this Oct 4, 2025
@tmszi tmszi added bug Something isn't working GUI wxGUI related backport to 8.4 PR needs to be backported to release branch 8.4 labels Oct 4, 2025
@github-actions github-actions bot added the Python Related code is in Python label Oct 4, 2025
petrasovaa
petrasovaa reviewed Oct 5, 2025
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution would be to do it consistently with InsertGrassDb and check that inside the InsertLocation method.

@tmszi
Copy link
Member Author

tmszi commented Oct 5, 2025

Another solution would be to do it consistently with InsertGrassDb and check that inside the InsertLocation method.

Yes you are right, it is better solution. Suggestion was incorporated by commit 3c28b5d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@tmszi tmszi

Labels
backport to 8.4 PR needs to be backported to release branch 8.4 bug Something isn't working GUI wxGUI related Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.

[Bug] wxGUI/datacatalog: newly created project via wizard is added twice into projects tree
2 participants
@tmszi @petrasovaa