Merge pull request #84 from thbeu/treat-warnings-as-errors

CI: treat all warnings as errors
OSGeo · Jan 22, 2024 · f88d88f · f88d88f
2 parents ad1886a + 29116cb
commit f88d88f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -61,7 +61,7 @@ jobs:
       uses: actions/checkout@v4
 
     - name: Configure (${{ matrix.configuration }})
-      run: cmake -S . -Bbuild -DCMAKE_BUILD_TYPE=${{ matrix.configuration }} -DCMAKE_UNITY_BUILD=ON
+      run: cmake -S . -Bbuild -DCMAKE_BUILD_TYPE=${{ matrix.configuration }} -DCMAKE_UNITY_BUILD=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON
 
     - name: Build with ${{ matrix.compiler }}
       run: cmake --build build

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -115,7 +115,9 @@ target_include_directories(${PACKAGE}
     $<INSTALL_INTERFACE:include>
 )
 
-if(NOT MSVC)
+if(MSVC)
+  target_compile_options(${PACKAGE} PRIVATE /W4)
+else()
   target_compile_options(${PACKAGE} PRIVATE -Wall -Wextra -pedantic)
 endif()
 

diff --git a/sbnsearch.c b/sbnsearch.c
@@ -139,13 +139,13 @@ SBNSearchHandle SBNOpenDiskTree(const char *pszSBNFilename,
     /* -------------------------------------------------------------------- */
     /*  Establish the byte order on this machine.                           */
     /* -------------------------------------------------------------------- */
-    bool bBigEndian;
+    bool _bBigEndian;
     {
         int i = 1;
         if (*REINTERPRET_CAST(unsigned char *, &i) == 1)
-            bBigEndian = false;
+            _bBigEndian = false;
         else
-            bBigEndian = true;
+            _bBigEndian = true;
     }
 
     /* -------------------------------------------------------------------- */
@@ -191,7 +191,7 @@ SBNSearchHandle SBNOpenDiskTree(const char *pszSBNFilename,
     memcpy(&hSBN->dfMaxX, abyHeader + 48, 8);
     memcpy(&hSBN->dfMaxY, abyHeader + 56, 8);
 
-    if (!bBigEndian)
+    if (!_bBigEndian)
     {
         SwapWord(8, &hSBN->dfMinX);
         SwapWord(8, &hSBN->dfMinY);