-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ADC and IVIM functions from NKI #13
Conversation
@@ -0,0 +1,239 @@ | |||
f# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This f
seems to be causing the test parser to choke.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I removed the f
that was causing this error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's missing a file? Is this important? ERROR src/original/PvH_KB_NKI/DWI_Examples.py - FileNotFoundError: [Errno 2] No such file or directory: '<YOUR_PATH>\\IVIM_b0_15_150_500.npy'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just change the path to the current directory so the function runs. Maybe add a comment with the YOUR_PATH so people know. I'll also try to see if there's a way to avoid these failures in the future.
Hey Koen, your code is now "failing" tests on Paulien's code. As a result, I could not find easiLy whether your code causes (additional) errors. I think you can remove the file "src/standardized/PV_MUMC_biexp.py" in your repository that would get rid of most of the fails. |
Merge main into your base
Added ADC and IVIM functions from NKI After removing code from main, the code gave no errors
Created folder PvH_KB_NKI. Adding DWI_Examples.py, DWI_functions_standalone.py, and IVIM_b0_15_150_500.npy.