Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ADC and IVIM functions from NKI #13

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Added ADC and IVIM functions from NKI #13

merged 7 commits into from
Oct 26, 2023

Conversation

KoenBaas
Copy link
Contributor

Created folder PvH_KB_NKI. Adding DWI_Examples.py, DWI_functions_standalone.py, and IVIM_b0_15_150_500.npy.

@@ -0,0 +1,239 @@
f# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This f seems to be causing the test parser to choke.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I removed the f that was causing this error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's missing a file? Is this important? ERROR src/original/PvH_KB_NKI/DWI_Examples.py - FileNotFoundError: [Errno 2] No such file or directory: '<YOUR_PATH>\\IVIM_b0_15_150_500.npy'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just change the path to the current directory so the function runs. Maybe add a comment with the YOUR_PATH so people know. I'll also try to see if there's a way to avoid these failures in the future.

@oliverchampion
Copy link
Collaborator

Hey Koen, your code is now "failing" tests on Paulien's code. As a result, I could not find easiLy whether your code causes (additional) errors. I think you can remove the file "src/standardized/PV_MUMC_biexp.py" in your repository that would get rid of most of the fails.

Merge main into your base
@oliverchampion oliverchampion merged commit bcba972 into OSIPI:main Oct 26, 2023
etpeterson pushed a commit to etpeterson/TF2.4_IVIM-MRI_CodeCollection that referenced this pull request Jul 19, 2024
Added ADC and IVIM functions from NKI
After removing code from main, the code gave no errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants