Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save test results to a json file & Display results Visuals on the website #73

Merged
merged 15 commits into from
Sep 15, 2024

Conversation

AhmedBasem20
Copy link
Contributor

No description provided.

@AhmedBasem20 AhmedBasem20 changed the title Save test results to a json file. Save test results to a json file & Display results Visuals on the website Aug 14, 2024
@AhmedBasem20
Copy link
Contributor Author

Hello @etpeterson, @oliverchampion
I managed to capture the expected and actual fitting values for each test and store them as a json file.
You can check the website here to see the results, please let me know if you have any comments, thanks.

Data point example:

         {
            "name": "Myocardium LV",
            "algorithm": "ETP_SRI_LinearFitting",
            "f_fit": 0.1851456126831551,
            "Dp_fit": 0.007000571619495537,
            "D_fit": 0.0023544011841776917,
            "f": 0.14999999999999997,
            "Dp": 0.08,
            "D": 0.0024,
            "status": "PASSED"
        }

Tolerance values:

    "rtol": {
        "f": 5,
        "D": 5,
        "Dp": 25
    },
    "atol": {
        "f": 0.01,
        "D": 0.01,
        "Dp": 0.1
    }

Copy link
Contributor

@etpeterson etpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logging needs to be changed in some way.

tests/IVIMmodels/unit_tests/test_ivim_fit.py Outdated Show resolved Hide resolved
tests/IVIMmodels/unit_tests/test_ivim_fit.py Outdated Show resolved Hide resolved
tests/IVIMmodels/unit_tests/test_ivim_fit.py Outdated Show resolved Hide resolved
tests/IVIMmodels/unit_tests/test_ivim_fit.py Outdated Show resolved Hide resolved
… report for the frontend with clear structure.

- Add the tolerance values for each test case instead of using fixed value for all tests.
.github/workflows/website.yml Show resolved Hide resolved
tests/IVIMmodels/unit_tests/test_ivim_fit.py Outdated Show resolved Hide resolved
website/dashboard/test_plots.js Outdated Show resolved Hide resolved
website/dashboard/test_plots.js Outdated Show resolved Hide resolved
website/dashboard/test_plots.js Outdated Show resolved Hide resolved
website/dashboard/test_plots.js Outdated Show resolved Hide resolved
website/dashboard/test_plots.js Outdated Show resolved Hide resolved
@AhmedBasem20
Copy link
Contributor Author

AhmedBasem20 commented Sep 9, 2024

Hey @etpeterson @oliverchampion Please check the following dashboard updates and let me know what you think:

  • I added default tolerance bounds that accurately wrap the data after visual testing.
  • Set data point color depending on the test status. (passed, failed, or xfailed).
  • Display algorithm and region when hovering over data points.

@etpeterson etpeterson merged commit 6c8a829 into OSIPI:main Sep 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants