Move to poetry #82
Merged
Move to poetry #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaefi
force-pushed
the
move_to_poetry
branch
from
332b2a7 to
b0b2b0c
Compare
Conan-Kudo
requested changes
Jan 25, 2025
Conan-Kudo
reviewed
Jan 25, 2025
Conan-Kudo
requested changes
Jan 25, 2025
|
Can you squash the mock-types commit with the first commit that removes python-mock? Also the setuptools commit can be squashed into the poetry one. |
schaefi
force-pushed
the
move_to_poetry
branch
from
325e845 to
c6b94e7
Compare
yes, done. I wanted to wait if you maybe had other findings that needs to be addressed |
Conan-Kudo
requested changes
Jan 26, 2025
We have no need for the rolling backport, as our needs are very simple.
schaefi
force-pushed
the
move_to_poetry
branch
from
c6b94e7 to
5cc0232
Compare
Conan-Kudo
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move project to poetry. Along with the move I also needed to apply the mock patch that was already applied to the stackbuild plugin