Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ramdisk install #2383

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix ramdisk install #2383

merged 2 commits into from
Oct 17, 2023

Conversation

schaefi
Copy link
Collaborator

@schaefi schaefi commented Oct 16, 2023

Fixed argument processing of config.bootoptions

Instead of adding an extra space to make the subsequent reading to work, use an awk script that does it without nasty workarounds. This Fixes the ramdisk deployment

Instead of adding an extra space to make the subsequent reading
to work, use an awk script that does it without nasty workarounds
@schaefi schaefi self-assigned this Oct 16, 2023
Copy link
Collaborator

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was also considering changing the while read approach to awk or similar tools. I think this is cleaner.

grep root= | cut -f2- -d=
)

[ -z "${root_uuid}" ] && exit 1
[ -z "${root_uuid}" ] && exit 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I like it, this is helpful for debugging 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that was also my intention here because we get no info on the generator call elsewhere

@schaefi schaefi merged commit c1e28ff into master Oct 17, 2023
10 checks passed
@schaefi schaefi deleted the fix_ramdisk_install branch October 17, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants