-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move FileSystem to context manager #2428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few places that look wonky or dangerous to me as the filesystem would be guaranteed to be unmounted far earlier than it was before (where it might never be unmounted).
Change the FileSystem class to be a context manager. All code using FileSystem was updated to the following with statement: with FileSystem.new(...) as filesystem: filesystem.some_member() This is related to Issue #2412
cherry picking merge commits is not easily possible. Thus get the list of commits and check if it can be applied in a series
17ee68c
to
075a58d
Compare
All integration tests have built with a Staging kiwi matching this PR, see
|
Use proper Union declaration for system variable and add consistency layer into Filesystem/VolumeManager classes to meet the type declaration as well as to simplify further refactoring on these classes
4aca8a2
to
abac4d0
Compare
Change the FileSystem class to be a context manager. All code using FileSystem was updated to the following with statement:
with FileSystem.new(...) as filesystem:
filesystem.some_member()
This is related to Issue #2412