Refactor disk builder for use with context manager #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dcermak I put you as a reviewer here but I think this sort of changes are not really reviewable. I plan to create a Staging release with this changes and let the integration tests run to see of any of them fails. So if you immediately spot something stupid that I have done feel free to comment :) Thanks much |
dcermak
reviewed
Jan 17, 2024
schaefi
force-pushed
the
refactor_disk_builder_for_further_context_manager
branch
from
5dcd0cd
to
3df46c7
Compare
dcermak
reviewed
Jan 18, 2024
dcermak
approved these changes
Jan 18, 2024
In preparation to further context manager related changes in VolumeManager, LuksDevice, RaidDevice and more the disk builder code which uses these classes needs to be refactored beforehand to allow switching to context manager based cascading of the storage device classes. This commit does the refactoring and is related to Issue #2412
schaefi
force-pushed
the
refactor_disk_builder_for_further_context_manager
branch
from
9ad8a51
to
a1783ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to further context manager related changes in VolumeManager, LuksDevice, RaidDevice and more the disk builder code which uses these classes needs to be refactored beforehand to allow switching to context manager based cascading of the storage device classes. This commit does the refactoring and is related to Issue #2412