-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for isomd5sum for tagging iso files #2615
Conversation
0ab0e24
to
8be281e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have to change RuntimeChecker.check_mediacheck_installed
, as I currently get this error:
[ ERROR ]: 15:23:31 | KiwiRuntimeError:
Required tool tagmedia not found in caller environment
The attribute 'mediacheck' is set to 'true' which requires
the above tool to be installed on the build system
9b509af
to
d89c0cf
Compare
Tests pass again, but now coverage fails... 😦
|
@schaefi, @davidcassany: either of you able to help me figure out how to close this coverage gap so this becomes green? |
The mocks were not setup correctly, I have force pushed a fix for |
The isomd5sum tool suite is used and available on all supported distributions except SUSE distributions, and is necessary to produce conformant ISOs for most Linux distributions. This change adds support for isomd5sum tool suite for kiwi, though it does not extend the kiwi-live dracut module to use it. The upstream dracut dmsquash-live module must be used instead. Co-authored-by: Dan Čermák <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should work now, at least a test build doesn't die immediately.
Does the documentation need updating somewhere?
Nope. The documentation for the kiwi.yml file is in the kiwi.yml file itself. |
The
isomd5sum
tool suite is used and available on all supported distributions except SUSE distributions, and is necessary to produce conformant ISOs for most Linux distributions.This change adds support for
isomd5sum
tool suite for kiwi, though it does not extend the kiwi-live dracut module to use it. The upstream dracutdmsquash-live
module must be used instead.