Add support for isomd5sum for tagging iso files #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
force-pushed
the
isomd5support
branch
8 times, most recently
from
0ab0e24
to
8be281e
Compare
Conan-Kudo
requested review from
schaefi,
davidcassany and
dcermak
and removed request for
schaefi and
davidcassany
dcermak
requested changes
Aug 20, 2024
There was a problem hiding this comment.
I believe we have to change RuntimeChecker.check_mediacheck_installed, as I currently get this error:
[ ERROR ]: 15:23:31 | KiwiRuntimeError:
Required tool tagmedia not found in caller environment
The attribute 'mediacheck' is set to 'true' which requires
the above tool to be installed on the build system
9b509af
to
d89c0cf
Compare
|
Tests pass again, but now coverage fails... 😦 |
|
@schaefi, @davidcassany: either of you able to help me figure out how to close this coverage gap so this becomes green? |
The mocks were not setup correctly, I have force pushed a fix for |
The isomd5sum tool suite is used and available on all supported distributions except SUSE distributions, and is necessary to produce conformant ISOs for most Linux distributions. This change adds support for isomd5sum tool suite for kiwi, though it does not extend the kiwi-live dracut module to use it. The upstream dracut dmsquash-live module must be used instead. Co-authored-by: Dan Čermák <[email protected]>
dcermak
reviewed
Aug 26, 2024
Nope. The documentation for the kiwi.yml file is in the kiwi.yml file itself. |
dcermak
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isomd5sumtool suite is used and available on all supported distributions except SUSE distributions, and is necessary to produce conformant ISOs for most Linux distributions.This change adds support for
isomd5sumtool suite for kiwi, though it does not extend the kiwi-live dracut module to use it. The upstream dracutdmsquash-livemodule must be used instead.