Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiwi/schema: Fix allowed value type for ISO publisher and application ID #2618

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Conan-Kudo
Copy link
Member

According to the spec, this should be constrained to 128 characters but also allow whitespaces. We didn't allow spaces in application ID, but allowed too much for Publisher.

Now we set up both correctly.

Fixes #2617.

According to the spec, this should be constrained to 128 characters
but also allow whitespaces. We didn't allow spaces in application ID,
but allowed too much for Publisher.

Now we set up both correctly.
@Conan-Kudo
Copy link
Member Author

@schaefi, @davidcassany: I'm pretty sure this necessitates a schema version bump, but I'm not sure how we handle implementing those.

@AdamWill
Copy link
Contributor

note this still isn't strictly correct. Per the spec, several other characters are allowed - ! " % & ' ( ) * + , - . / : ; < = > ?. The more restrictive character set (just upper-case letters, numbers, and the underscore) is referred to in the spec as "d-characters", and used for e.g. the volume ID. The less restrictive set is referred to as "a-characters", and used for the application ID and publisher (and also the data preparer, the system identifier, and the "standard identifier", though that is always the same string anyway).

@Conan-Kudo
Copy link
Member Author

Well, this isn't merged yet, so I can certainly add those in too. 😄

@schaefi
Copy link
Collaborator

schaefi commented Aug 26, 2024

@schaefi, @davidcassany: I'm pretty sure this necessitates a schema version bump, but I'm not sure how we handle implementing those.

Well so far we did not bump the schema version for this cases. You changed the strictness of a pattern applied to an attribute. Strictly speaking the schema did not change on any attribute or element or semantic structure. From that perspective no XSLT conversion is needed from old to new and thus we usually don't bump the schema version for such a change.

The version of kiwi itself will be bumped on a new tag that includes your change. Thus the increase of the pattern strictness can still be detected by a version compare of kiwi itself.

From my perspective this change can go in as soon as @AdamWill is fine with the final pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISO application ID disallows spaces
3 participants