Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootloader: Fix up ppc64 bootinfo again #2644

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

hramrach
Copy link
Contributor

To make the code look pretty extra newline is inserted at the start of bootinfo file. This appears to break boot on Power9 PowerVM LPARs.

Fixes bsc#1210888

Changes proposed in this pull request:

  • Remove newline at the start of bootinfo.txt

@wfeldt
Copy link
Collaborator

wfeldt commented Sep 12, 2024

The construct they use in connection to dedent in kiwi is

dedent('''
XXX
''').strip() + os.linesep

I would stick to that - it keeps the formatting nice.

To make the code look pretty extra newline is inserted at the start of
bootinfo file. This appears to break boot on Power9 PowerVM LPARs.
Copy link
Collaborator

@wfeldt wfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Conan-Kudo Conan-Kudo merged commit b6194e8 into OSInside:main Sep 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants