Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix musl chromium build #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

concatime
Copy link

Fixes #578.

Copy link
Collaborator

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see these patches being applied via chromium-gn.inc so how are they supposed to work?
secondly, I am still bewildered on how to reproduce the failures you are seeing. There much be something thats different in your environment that I am not seeing here. Since build succeeds without these patches for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

chromium: libsync includes the nonexistant sys/cdefs.h in musl
2 participants