Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PositionInterface, OrientationInterface, and PoseInterface need optional transform update behavior #61

Open
JeroMiya opened this issue Jul 9, 2015 · 4 comments

Comments

@JeroMiya
Copy link
Contributor

JeroMiya commented Jul 9, 2015

RequiresPositionInterface, RequiresOrientationInterface, and RequiresPoseInterface are convenient base classes for a behavior that requires one of those interface components in its own logic. However, those behaviors currently always update their parent game object's transform (position or rotation or both). This should be optional in case the dependent behavior wants to take over the transform modification. A true/false property that can be set in the editor (like the path), which disables the code that updates the parent object's position and orientation.

We may also want to expose something to RequiresFooInterface subclasses to enable/disable the update behavior programmatically instead of relying on the editor flag to be set a certain way.

@DuFF14
Copy link
Member

DuFF14 commented Jul 9, 2015

Not sure what you mean. Do any of the prefabs have this behavior? Maybe you can provide an example where an interface is updating its parent game object?

Also, I didn't catch this earlier, but I think now that we're using state APIs in these interfaces, transform updates should be happening in LateUpdate rather than Update, as this is closer to the time when the image will be displayed on the screen.

@JeroMiya
Copy link
Contributor Author

I meant the transform updates in their respective Update methods.

@JeroMiya
Copy link
Contributor Author

@DuFF14 Do you have any hardware to measure actual tracking lag? I was testing using LateUpdate as you suggested to see if it improved the visual lag, and it seemed to, but I can't really tell. My Razor Hydras have very little lag, but I'm experiencing some pretty bad lag on the HDK 1.0. I always have though, so it may just be the hardware or something in my setup.

@peroht
Copy link

peroht commented Sep 19, 2015

@JeroMiya are you experiencing the smoothening effect of the 1 euro filter as a tracking lag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants