Vis snakemake updates #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-If snakemake added -Removed connections to configuration.py -Moved visualise.py and supporting functions (e.g. in constants, utils) to osemosys_global/visualisation
trevorb1
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
LGTM @maartenbrinkerink! I didn't do a super detailed review as functionality isnt changing. But I tried this on two different config files and it ran fine on my side :)
|
Grand! Testing it now on the ASEAN branch and will merge if that is also successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-If snakemake added
-Removed connections to configuration.py
-Moved visualise.py and supporting functions (e.g. in constants, utils) to osemosys_global/visualisation