feat(cluster): add event recording functionality for RedisCluster controller. #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the Scheme field from the Reconciler struct in rediscluster_controller.go, main.go, and rediscluster_controller_suite_test.go as it was not being utilized. - This cleanup enhances code clarity and maintainability by eliminating unnecessary components. Signed-off-by: [Your Name] Signed-off-by: drivebyer <[email protected]>
…troller - Introduced a new events package to manage event recording, including a Recorder struct and methods for adding and retrieving events. - Updated the RedisCluster controller to utilize the event recorder, allowing it to log downscale events. - Enhanced the main function to initialize the event recorder for the RedisCluster controller. This update improves observability capabilities for RedisCluster operations. Signed-off-by: [Your Name] Signed-off-by: drivebyer <[email protected]>
drivebyer
requested review from
shubham-cmyk and
iamabhishek-dubey
as code owners
Signed-off-by: drivebyer <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1182 +/- ##
==========================================
- Coverage 30.20% 29.89% -0.31%
==========================================
Files 55 56 +1
Lines 6294 6446 +152
==========================================
+ Hits 1901 1927 +26
- Misses 4200 4326 +126
Partials 193 193 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist
Additional Context